Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Openhome library #7671

Merged
merged 2 commits into from May 20, 2017

Conversation

bazwilliams
Copy link
Contributor

@bazwilliams bazwilliams commented May 20, 2017

Description:

This increases the version of the openhomedevice library to 0.4.0 for openhome compliant media players and introduces support for a new service available on these device.

Related issue (if applicable): None

Pull request in home-assistant.github.io with documentation (if applicable): No documentation changes required

Example entry for configuration.yaml (if applicable):

No configuration changes required

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@mention-bot
Copy link

@bazwilliams, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @pvizeli and @fabaff to be potential reviewers.

@bazwilliams bazwilliams changed the title Openhome transport service Upgrade Openhome library May 20, 2017
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit adde9e6 into home-assistant:dev May 20, 2017
@balloob balloob mentioned this pull request Jun 2, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants