Update concord232.py to fix the home/stay command

[CTLS]

Description:

Related issue (if applicable): fixes #5049

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• Tests have been added to verify that the new code works.

[mention-bot]

@CTLS, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JasonCarter80, @fabaff and @pvizeli to be potential reviewers.

[homeassistant]

Hi @CTLS,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[CTLS]

I have not solved why the away mode does not work still, but this allows the stay/ home mode to work so at least the alarm can be armed and disarmed.

[MartinHjelmare]

Did you try the 'exit' arm type as mentioned in #2194?

[CTLS]

Just tried that and it doesn't work. I am not sure if it is an error with the concord232 server or the component.

[CTLS]

After looking at the code of the concord232 server and comparing to the nx584 which it was built off of it looks like the concord232 server is missing the code for away mode and auto. I believe updating the stay code as I have changed it is the best that can be done on this side everything else would need to be updated on the concord232 server code by @JasonCarter80 and not in the home assistant component.

[MartinHjelmare]

Ok. If you know what to fix upstream, you can make a PR to concord232, and hopefully get that in.

I'll merge this now. This will autoclose #5049. Either open a new issue for the remaining problem or let me know in #5049 if we should keep that open.

[JasonCarter80]

My Concord is offline, so I can't test any pull. If you submit a PR to the Concord I can add you as an admin to the repo to help maintain it.-- Best Regards, Jason Carter m: (813)-516-5861 e: jason@jason-carter.net "Anyone who stops learning is old, whether at twenty or eighty" - Henry Ford

On Sun, May 28, 2017, at 01:37 AM, CTLS wrote: After looking at the code of the concord232 server and comparing to the nx584 which it was built off of it looks like the concord232 server is missing the code for away mode and auto. I believe updating the stay code as I have changed it is the best that can be done on this side everything else would need to be updated on the concord232 server code by @JasonCarter80[1] and not in the home assistant component.> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[2], or mute the thread[3].>

Links: 1. https://github.com/jasoncarter80 2. #7789 (comment) 3. https://github.com/notifications/unsubscribe-auth/AAot94qg2BLT2a1hg_RPjmnO8lgernz1ks5r-QgKgaJpZM4NoF7a