Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display all input sources / Add support for favourite channels / Treat Marantz SR5008 as Denon AVR-X device #7949

Merged
merged 4 commits into from Jun 8, 2017

Conversation

ol-iver
Copy link
Contributor

@ol-iver ol-iver commented Jun 7, 2017

Description:

Pushed to version 0.4.3 of the library including following changes:

  • Add option (show_all_sources) to display all input sources also those marked as deleted
  • Add support for favourite channels
  • Treat Marantz SR5008 as Denon AVR-X device
  • Add Marantz NETWORK audio source

Config

 media_player:
    - platform: denonavr
      host: IP_ADDRESS (optional)
      name: RECEIVER_NAME (optional)
      show_all_sources: True / False (optional)

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2786

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@mention-bot
Copy link

@scarface-4711, thanks for your PR! By analyzing the history of the files in this pull request, we identified @happyleavesaoc, @fabaff and @balloob to be potential reviewers.

@@ -37,6 +39,7 @@
PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
vol.Optional(CONF_HOST): cv.string,
vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
vol.Optional(CONF_SHOW_ALL_SOURCES, default=DEFAULT_SHOW_SOURCES): cv.boolean,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (82 > 79 characters)

@pvizeli pvizeli merged commit 482db94 into home-assistant:dev Jun 8, 2017
@ol-iver ol-iver deleted the denonavr branch June 11, 2017 01:16
@balloob balloob mentioned this pull request Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants