Vizio SmartCast support #8260
Merged
Vizio SmartCast support #8260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vkorn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
fabaff
requested changes
Jul 6, 2017
| host = config.get(CONF_HOST) | ||
| if host is None: | ||
| _LOGGER.error('No host info') | ||
| return False |
There was a problem hiding this comment.
That's covered by the configuration validation. CONF_HOST will never been None.
| token = config.get(CONF_ACCESS_TOKEN) | ||
| if token is None: | ||
| _LOGGER.error('No token info') | ||
| return False |
| from homeassistant.helpers import config_validation as cv | ||
|
|
||
| REQUIREMENTS = ['git+https://github.com/vkorn/pyvizio.git' | ||
| '@master#pyvizio==0.0.1'] |
There was a problem hiding this comment.
Can you publish your module at PyPI?
| return False | ||
| name = config.get(CONF_NAME) | ||
|
|
||
| add_devices([VizioDevice(host, token, name)], True) |
There was a problem hiding this comment.
Checking that the host is reachable and the token valid before setting up the platform would help that the users don't end up with a non-functional platform in their setup.
|
It looks like this branch got messed up. Can you clean up the unrelated commits? |
Added new config params
Added new config params
fabaff
approved these changes
Jul 11, 2017
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Vizio SmartCast support * Requested changes Added new config params * Vizio SmartCast support * Requested changes Added new config params
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Support of newer Vizio TV models (with SmartCast capabilities).
One annoying thing: Vizio serving https without certificate, so lot of warnings will be in the log if loglevel is low. As an option -- proxy requests through nginx.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2906
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.