Use upstream RachioPy, fix manual run switches #8286
Conversation
|
@Klikini, thanks for your PR! By analyzing the history of the files in this pull request, we identified @andrey-git to be a potential reviewer. |
| @@ -8,7 +8,7 @@ | |||
| from homeassistant.components.switch import SwitchDevice, PLATFORM_SCHEMA | |||
| from homeassistant.const import CONF_ACCESS_TOKEN | |||
|
|
|||
| REQUIREMENTS = ['rachiopy==0.1.2'] | |||
| REQUIREMENTS = ['rachiopy==0.1.1'] | |||
There was a problem hiding this comment.
Any reason for downgrading the dependency?
There was a problem hiding this comment.
0.1.2 was a version I created in my fork of RachioPy for A/B testing. I decided that 0.1.1 works better, so I never pushed 0.1.2 upstream.
There was a problem hiding this comment.
But 0.1.2 is the one available on PyPI and seems to be the release created by the upstream project.
There was a problem hiding this comment.
I just checked, and @rfverbruggen released his own update to it 10 days ago. It doesn't look like anything that would break this integration, but it'll need testing.
There was a problem hiding this comment.
Seems like we have always used the upstream version, never your fork? We should not downgrade unless necessary. Please revert this change
* use upstream RachioPy, fix manual run switches * Update requirements for PyPi version of rachiopy * Use upstream RachioPy 0.1.2 (partial revert of https://github.com/Klikini/home-assistant/commit/39c6484d89337240918ffe60c35705b5b3405705) * Revert rachiopy downgrade
ghost
added
Description:
Related issue (if applicable): fixes #7921 #7973
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.