Add support for IntesisHome controllable air conditioners #8316

jnimmo · 2017-07-03T09:09:20Z

Description:

Added support for IntesisHome controlled air conditioners.
Work in progress, first time submitting a component so please let me know if anything needs changing.
This platform has been in use by a number of testers on https://community.home-assistant.io/t/add-support-for-intesishome-wifi-ac-control/5172 - initially was added as an IntesisHome platform and climate component however combined it into the one climate component.

Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.io#2925

Example entry for `configuration.yaml` (if applicable):

climate:
  - platform: intesishome
    username: 'user'
    password: 'pass'

Checklist:

If user exposed functionality or configuration variables are added/changed:

[Y] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[Y] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[Y] New dependencies have been added to the REQUIREMENTS variable (example).
[?] New dependencies are only imported inside functions that use them (example).
[Y] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[Y] New files were added to .coveragerc.

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

homeassistant · 2017-07-03T09:09:22Z

Hi @jnimmo,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

houndci-bot · 2017-07-03T09:09:31Z

homeassistant/components/climate/intesishome.py

+    @property
+    def is_away_mode_on(self):
+        """Return if away mode is on."""
+        return None


no newline at end of file

houndci-bot · 2017-07-03T09:09:31Z

homeassistant/components/climate/intesishome.py

+    def update_callback(self):
+        """Called when data is received by pyIntesishome"""
+        _LOGGER.debug("IntesisHome sent a status update.")
+        self.hass.async_add_job(self.update_ha_state,True)


missing whitespace after ','

houndci-bot · 2017-07-03T09:09:31Z

homeassistant/components/climate/intesishome.py

+        intesishome.poll_status(shouldCallback)
+
+
+    @property


too many blank lines (2)

houndci-bot · 2017-07-03T09:09:32Z

homeassistant/components/climate/intesishome.py

+            self._swing = STATE_UNKNOWN
+
+
+    @Throttle(MIN_TIME_BETWEEN_UPDATES)


too many blank lines (2)

houndci-bot · 2017-07-03T09:09:32Z

homeassistant/components/climate/intesishome.py

+            self._current_operation = STATE_UNKNOWN
+
+        # Target temperature
+        if self._current_operation in [STATE_OFF,STATE_FAN]:


missing whitespace after ','

houndci-bot · 2017-07-03T09:09:32Z

homeassistant/components/climate/intesishome.py

+        self._fan_speed = STATE_UNKNOWN
+        self._current_operation = STATE_UNKNOWN
+
+        self._operation_list = [STATE_AUTO, STATE_COOL, STATE_HEAT, STATE_DRY, STATE_FAN, STATE_OFF]


line too long (100 > 79 characters)

houndci-bot · 2017-07-03T09:09:32Z

homeassistant/components/climate/intesishome.py

+class IntesisAC(ClimateDevice):
+    def __init__(self, deviceid, device):
+        """Initialize the thermostat"""
+        _LOGGER.debug('Added climate device with state: %s',repr(device))


missing whitespace after ','

houndci-bot · 2017-07-03T09:09:32Z

homeassistant/components/climate/intesishome.py

+                 for deviceid, device in intesishome.get_devices().items()])
+    return True
+
+class IntesisAC(ClimateDevice):


expected 2 blank lines, found 1

houndci-bot · 2017-07-03T09:09:32Z

homeassistant/components/climate/intesishome.py

+    add_devices([IntesisAC(deviceid, device)
+                 for deviceid, device in intesishome.get_devices().items()])
+    return True
+


blank line contains whitespace

houndci-bot · 2017-07-03T09:09:32Z

homeassistant/components/climate/intesishome.py

+        intesishome.connect()
+
+    if intesishome.error_message:
+        persistent_notification.create(hass, intesishome.error_message, "IntesisHome Error", 'intesishome')


line too long (107 > 79 characters)

homeassistant · 2017-07-03T09:25:03Z

Hi @jnimmo,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+        self._operation_list = [STATE_AUTO, STATE_COOL, STATE_HEAT, STATE_DRY,
+                               STATE_FAN, STATE_OFF]
+        self._fan_list = [STATE_AUTO, STATE_QUIET, STATE_LOW, STATE_MEDIUM,
+                         STATE_HIGH]


continuation line under-indented for visual indent

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+        self._current_operation = STATE_UNKNOWN
+
+        self._operation_list = [STATE_AUTO, STATE_COOL, STATE_HEAT, STATE_DRY,
+                               STATE_FAN, STATE_OFF]


continuation line under-indented for visual indent

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+
+    if intesishome.error_message:
+        persistent_notification.create(hass, intesishome.error_message,
+        "IntesisHome Error", 'intesishome')


continuation line under-indented for visual indent

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+    _pass = config.get(CONF_PASSWORD)
+
+    if intesishome is None:
+        intesishome = IntesisHome(_user,_pass, hass.loop)


missing whitespace after ','

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+
+    _user = config.get(CONF_USERNAME)
+    _pass = config.get(CONF_PASSWORD)
+


blank line contains whitespace

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+})
+
+# Return cached results if last scan time was less than this value.
+# If a persistent connection is established for the controller, changes to values are in realtime.


line too long (98 > 79 characters)

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+from homeassistant.components.climate import ( ClimateDevice,
+    PLATFORM_SCHEMA, ATTR_TARGET_TEMP_HIGH, ATTR_TARGET_TEMP_LOW,
+    ATTR_TEMPERATURE, ATTR_OPERATION_MODE)
+from homeassistant.const import (TEMP_CELSIUS, CONF_SCAN_INTERVAL, STATE_UNKNOWN)


'homeassistant.const.CONF_SCAN_INTERVAL' imported but unused
line too long (81 > 79 characters)

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+from homeassistant.components import persistent_notification
+from homeassistant.components.climate import ( ClimateDevice,
+    PLATFORM_SCHEMA, ATTR_TARGET_TEMP_HIGH, ATTR_TARGET_TEMP_LOW,
+    ATTR_TEMPERATURE, ATTR_OPERATION_MODE)


continuation line under-indented for visual indent

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+from homeassistant.util import Throttle
+from homeassistant.components import persistent_notification
+from homeassistant.components.climate import ( ClimateDevice,
+    PLATFORM_SCHEMA, ATTR_TARGET_TEMP_HIGH, ATTR_TARGET_TEMP_LOW,


continuation line under-indented for visual indent

houndci-bot · 2017-07-03T09:25:10Z

homeassistant/components/climate/intesishome.py

+from homeassistant.const import (CONF_PASSWORD, CONF_USERNAME, CONF_STRUCTURE)
+from homeassistant.util import Throttle
+from homeassistant.components import persistent_notification
+from homeassistant.components.climate import ( ClimateDevice,


'homeassistant.components.climate.ATTR_TARGET_TEMP_HIGH' imported but unused
'homeassistant.components.climate.ATTR_TARGET_TEMP_LOW' imported but unused
whitespace after '('

houndci-bot · 2017-07-03T09:32:44Z

homeassistant/components/climate/intesishome.py

+})
+
+# Return cached results if last scan time was less than this value.
+# If a persistent connection is established for the controller, 


trailing whitespace

houndci-bot · 2017-07-03T09:34:36Z

homeassistant/components/climate/intesishome.py

+    def is_away_mode_on(self):
+        """Return if away mode is on."""
+        return None
+


blank line at end of file

This reverts commit 02baeb9.

houndci-bot · 2017-07-04T09:13:49Z

homeassistant/components/climate/intesishome.py

+
+class IntesisAC(ClimateDevice):
+    """Representation of an IntesisHome thermostat."""
+


blank line contains whitespace

This reverts commit 85ebbe6.

jnimmo · 2017-07-04T09:41:59Z

I'm not sure how to resolve the following issues from Travis - is someone able to kindly advise?
The intesishome variable is designed to be a singleton i.e. one interface back to the IntesisHome API, and then the IntesisAC objects maintain their state from that one intesishome object.

C: 55, 0: Invalid constant name "intesishome" (invalid-name)
C: 61, 4: Invalid constant name "intesishome" (invalid-name)
R:251, 4: Method could be a function (no-self-use)
W: 48, 4: Unused ensure_future imported from asyncio (unused-import)

Landrash · 2017-07-04T10:38:04Z

Suggest you update the description file to include your .io PR.
home-assistant/home-assistant.io#2925

fabaff · 2017-07-08T14:29:13Z

homeassistant/components/climate/intesishome.py

+def setup_platform(hass, config, add_devices, discovery_info=None):
+    """Set up the IntesisHome interface."""
+    from pyintesishome import IntesisHome
+    global INTESISHOME


Please use hass.data.

Thanks for your review Fabian, I've now switched the platform over to using hass.data

fabaff · 2017-07-08T14:29:36Z

.coveragerc

@@ -228,6 +228,7 @@ omit =
    homeassistant/components/climate/proliphix.py
    homeassistant/components/climate/radiotherm.py
    homeassistant/components/climate/sensibo.py
+    homeassistant/components/climate/intesishome.py


Please keep the list alphabetically ordered.

Replaced with hass.data['climate_intesishome']

Migrated to using hass.data[‘climate_intesishome’]

houndci-bot · 2017-08-04T10:28:59Z

homeassistant/components/climate/intesishome.py

+                self._intesishome.set_mode_dry(self._deviceid)
+
+            if self._target_temp:
+                self._intesishome.set_temperature(self._deviceid, self._target_temp)


line too long (84 > 79 characters)

houndci-bot · 2017-08-04T10:34:49Z

homeassistant/components/climate/intesishome.py

+                self._intesishome.set_mode_dry(self._deviceid)
+
+            if self._target_temp:
+                self._intesishome.set_temperature(self._deviceid, 


trailing whitespace

MartinHjelmare

Use the common climate states already defined in the climate component for representing the operation_mode state in home assistant. Implement conversion logic to go between home assistant states and device specific states.

MartinHjelmare · 2017-08-07T10:50:39Z

homeassistant/components/climate/intesishome.py

+
+import logging
+from datetime import timedelta
+import voluptuous as vol


Add a blank line between standard library, third party and homeassistant imports.
https://www.python.org/dev/peps/pep-0008/#imports

from datetime import timedelta import voluptuous as vol

MartinHjelmare · 2017-08-07T10:52:26Z

homeassistant/components/climate/intesishome.py

+from datetime import timedelta
+import voluptuous as vol
+import homeassistant.helpers.config_validation as cv
+from homeassistant.const import (CONF_PASSWORD, CONF_USERNAME, CONF_STRUCTURE)


Sort the import lines alphabetically within each bigger group, standard, 3rd party and homeassistant, and also sort each imported object alphabetially on the same line.

MartinHjelmare · 2017-08-07T10:53:31Z

homeassistant/components/climate/intesishome.py

+_LOGGER = logging.getLogger(__name__)
+
+DEFAULT_NAME = 'IntesisHome'
+REQUIREMENTS = ['pyintesishome==0.4']


Place this right after imports.
https://home-assistant.io/developers/development_guidelines/#requirements

MartinHjelmare · 2017-08-07T10:59:55Z

homeassistant/components/climate/intesishome.py

+STATE_LOW = 'Low'
+STATE_MEDIUM = 'Medium'
+STATE_HIGH = 'High'
+STATE_OFF = 'Off'


Home assistant should use its own state names for the climate platforms in the GUI and automation API and convert to device specific states before interacting with a climate device.

Implement two conversion dicts that converts the device specific states to home assistant states and vice versa. Rename the constants you've defined here so that it's clear that they are device specific, and then import the home assistant states from climate base component and const.py.

MartinHjelmare · 2017-08-07T11:02:18Z

homeassistant/components/climate/intesishome.py

+    # Python 3.4.3 and ealier has this as async
+    # pylint: disable=unused-import
+    from asyncio import async
+    ensure_future = async


ensure_future is not used.

MartinHjelmare · 2017-08-07T11:27:53Z

homeassistant/components/climate/intesishome.py

+        fan_speed = self._intesishome.get_fan_speed(self._deviceid)
+        if fan_speed:
+            # Capitalize fan speed from pyintesishome
+            self._fan_speed = fan_speed[:1].upper() + fan_speed[1:]


Use https://docs.python.org/3/library/stdtypes.html#str.capitalize

MartinHjelmare · 2017-08-07T11:30:41Z

homeassistant/components/climate/intesishome.py

+        return self._target_temp
+
+    @property
+    def target_temperature_low(self):


Remove if not overwritten.

MartinHjelmare · 2017-08-07T11:30:48Z

homeassistant/components/climate/intesishome.py

+        return None
+
+    @property
+    def target_temperature_high(self):


Remove if not overwritten.

MartinHjelmare · 2017-08-07T11:30:58Z

homeassistant/components/climate/intesishome.py

+        return None
+
+    @property
+    def is_away_mode_on(self):


Remove if not overwritten.

MartinHjelmare · 2017-08-07T11:33:47Z

homeassistant/components/climate/intesishome.py

+        if 42 in device.get('widgets'):
+            self._has_swing_control = True
+
+        self._intesishome.add_update_callback(self.update_callback)


Move this to a async_added_to_hass method.

andrey-git · 2017-08-22T07:43:56Z

@jnimmo any updates on this PR?

pandaedward · 2017-08-22T23:48:05Z

homeassistant/components/climate/intesishome.py

+    def update_callback(self):
+        """Called when data is received by pyIntesishome."""
+        _LOGGER.debug("IntesisHome sent a status update.")
+        self.hass.async_add_job(self.update_ha_state, True)


Hi there,

I have a lot of deprecation warning assuming caused by this line.

WARNING (Thread-5) [homeassistant.helpers.entity] 'update_ha_state' is deprecated. Use 'schedule_update_ha_state' instead.

pandaedward · 2017-08-22T23:49:25Z

Waiting on this PR as well.

@jnimmo Just put in a comment in intesishome.py line 277, lots of deprecation warning

pvizeli · 2017-08-25T07:43:37Z

Can be reopen if all comments are addressed

jnimmo added 2 commits July 3, 2017 20:51

Added IntesisHome climate component

9b5476e

Updated coverage

902f9e7

homeassistant added new-platform platform: climate.intesishome cla-needed labels Jul 3, 2017

houndci-bot reviewed Jul 3, 2017

View reviewed changes

Resolved Hound style issues

5b6398a

homeassistant added the cla-needed label Jul 3, 2017

houndci-bot reviewed Jul 3, 2017

View reviewed changes

homeassistant added cla-signed and removed cla-needed labels Jul 3, 2017

Resolved more Hound issues

57d4fd2

homeassistant added the cla-signed label Jul 3, 2017

houndci-bot reviewed Jul 3, 2017

View reviewed changes

More Hound issues

02baeb9

houndci-bot reviewed Jul 3, 2017

View reviewed changes

jnimmo added 2 commits July 3, 2017 21:34

Revert "More Hound issues"

929e494

This reverts commit 02baeb9.

More hound issues

cb6aaba

jnimmo mentioned this pull request Jul 3, 2017

Add IntesisHome climate component home-assistant/home-assistant.io#2925

Closed

jnimmo added 3 commits July 3, 2017 22:27

Updated for Lint

976fdd1

Travis Lint issues

e610642

Added required blank line

85ebbe6

houndci-bot reviewed Jul 4, 2017

View reviewed changes

jnimmo added 2 commits July 4, 2017 21:17

Revert "Added required blank line"

0b432c5

This reverts commit 85ebbe6.

Added required blank line

cbe605b

Hopefully fixed Lint issues

a8ce802

balloobbot added platform requirement labels Jul 5, 2017

Hopefully resolved Lint issues

701ead3

homeassistant added the cla-signed label Jul 5, 2017

Fixed Lint issue

c3ca5cb

fabaff reviewed Jul 8, 2017

View reviewed changes

jnimmo added 2 commits August 4, 2017 22:28

Removed global variable

31357fe

Replaced with hass.data['climate_intesishome']

Removed global variable

6e2fe65

Migrated to using hass.data[‘climate_intesishome’]

houndci-bot reviewed Aug 4, 2017

View reviewed changes

jnimmo added 2 commits August 4, 2017 22:33

Merge remote-tracking branch 'home-assistant/dev' into dev

080acb2

Fix long line

bfd460e

houndci-bot reviewed Aug 4, 2017

View reviewed changes

jnimmo added 2 commits August 4, 2017 22:35

Trailing whitespace

efd1170

Fixed disable unused import

88c49ae

MartinHjelmare requested changes Aug 7, 2017

View reviewed changes

pandaedward reviewed Aug 22, 2017

View reviewed changes

pvizeli closed this Aug 25, 2017

home-assistant locked and limited conversation to collaborators Dec 11, 2017

ghost added integration: intesishome and removed platform: climate.intesishome labels Mar 21, 2019

		self._swing = STATE_UNKNOWN


		@Throttle(MIN_TIME_BETWEEN_UPDATES)


		_user = config.get(CONF_USERNAME)
		_pass = config.get(CONF_PASSWORD)


		class IntesisAC(ClimateDevice):
		"""Representation of an IntesisHome thermostat."""

Add support for IntesisHome controllable air conditioners #8316

Add support for IntesisHome controllable air conditioners #8316

Conversation

jnimmo commented Jul 3, 2017 • edited

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

homeassistant commented Jul 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

homeassistant commented Jul 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnimmo commented Jul 4, 2017

Landrash commented Jul 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MartinHjelmare left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MartinHjelmare Aug 7, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrey-git commented Aug 22, 2017

Choose a reason for hiding this comment

pandaedward commented Aug 22, 2017

pvizeli commented Aug 25, 2017

jnimmo commented Jul 3, 2017 •

edited

Example entry for `configuration.yaml` (if applicable):

MartinHjelmare Aug 7, 2017 •

edited