Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues for PyLint 1.7.2 #8356

Merged
merged 3 commits into from Jul 6, 2017

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

commented Jul 5, 2017

Description:

This fixes some of the issues that PyLint 1.7.2 is reporting. Plan is to fix them all and upgrade PyLint 馃憤

Related issue (if applicable): #7108

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 5779d64 into dev Jul 6, 2017

5 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.603%
Details
hound No violations found. Woof!

@balloob balloob deleted the pylint-upgrade branch Jul 6, 2017

@balloob balloob referenced this pull request Jul 13, 2017

Merged

0.49 #8468

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

Fix some issues for PyLint 1.7.2 (home-assistant#8356)
* Fix some issues for PyLint 1.7.2

* More fixes

* Revert position change for cover

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can鈥檛 perform that action at this time.