Fix TP-Link device tracker regression since 0.49 #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regression was introduced by home-assistant#8322. Fix is to utf encode the password like the other TP-Link backends do.
|
@maikelwever, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @mKeRix and @michaelarnauts to be potential reviewers. |
houndci-bot
reviewed
Jul 16, 2017
| @@ -391,7 +391,7 @@ def _update_info(self): | |||
| "Cache-Control": "no-cache" | |||
| } | |||
|
|
|||
| password_md5 = hashlib.md5(self.password).hexdigest().upper() | |||
| password_md5 = hashlib.md5(self.password.encode('utf')).hexdigest().upper() | |||
There was a problem hiding this comment.
line too long (87 > 79 characters)
Commit in question: 677f3fb
|
Thanks! |
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Fix TP-Link device tracker regression since 0.49 This regression was introduced by home-assistant#8322. Fix is to utf encode the password like the other TP-Link backends do. * Fix linting issue introduced in previous commit Commit in question: 677f3fb
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix TP-Link device tracker regression since 0.49
This regression was introduced by #8322.
Because all backends are attempted, and the broken one is first in line, this breaks other routers than the addition from the PR as well.
Fix is to utf encode the password like the other TP-Link backends do.
Traceback generated by the regression:
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass