Pilight switch: restore last state after restart #8580

janLo · 2017-07-21T01:31:06Z

Description:

This uses the restore_state helper to set the last known state to
pilight switches when the devices are initialized after a HA
restart.

Without this HA forget the state on every restart and needs to be told
the state by retoggling the switches. This can cause unwanted effects
as a switch toggling may emit an RF signal.

Checklist:

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass

mention-bot · 2017-07-21T01:31:07Z

@janLo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DavidLP and @fabaff to be potential reviewers.

pvizeli

That is not the correct flow for restore a flow. Look into input_boolean to see the correct workflow on entity. please add also:

   @property 
     def assumed_state(self) -> bool: 
         """Return True if unable to access real state of the entity.""" 
         return True

janLo · 2017-07-21T15:49:13Z

I don't understand what you mean with a workflow. Also there is no async_added_to_hass in the Pilight switch. I don't understand what assumed_state should give, I only want to restore the previous state if there is one, not change any behavior.

pvizeli · 2017-07-23T15:28:27Z

for history, we explain it on discord

EDIT:
You need add async_added_to_hass on that object. Also assumed_state should be set while it is true that we have no access to right state of it.

janLo · 2017-07-25T09:56:40Z

I can do and test that after August the 14th. Please leave the PR open.

houndci-bot · 2017-07-26T13:57:37Z

homeassistant/components/switch/pilight.py

+        """Call when entity about to be added to hass."""
+        if self.entity_id is None:
+            self.entity_id = generate_entity_id(
+                ENTITY_ID_FORMAT, name, hass=hass)


undefined name 'name'
undefined name 'hass'

houndci-bot · 2017-07-26T13:57:38Z

homeassistant/components/switch/pilight.py

+                                 CONF_PROTOCOL, STATE_ON)
+from homeassistant.helpers.entity import generate_entity_id
+from homeassistant.helpers.restore_state import async_get_last_state
+from homeassistant.util.async import run_coroutine_threadsafe


'homeassistant.util.async.run_coroutine_threadsafe' imported but unused

janLo · 2017-07-26T13:58:09Z

Found a few minutes before my holiday. It seems to work like the solution before.

janLo · 2017-07-26T14:06:02Z

And fixed a copy/paste error

janLo · 2017-07-26T15:43:01Z

@pvizeli Should be alright now?

pvizeli · 2017-07-28T12:17:52Z

homeassistant/components/switch/pilight.py

+        """Call when entity about to be added to hass."""
+        if self.entity_id is None:
+            self.entity_id = generate_entity_id(
+                ENTITY_ID_FORMAT, self._name, hass=self._hass)


Remove this part

@pvizeli done.

This uses the restore_state helper to set the last known state to pilight switches when the devices are initialized after a HA restart. Without this HA forget the state on every restart and needs to be told the sttae by retoggling the switches. This can cause unwanted effects as a switch toggling may emit an RF signal.

Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>

houndci-bot · 2017-08-17T13:33:46Z

homeassistant/components/switch/pilight.py

@@ -12,10 +13,15 @@
 import homeassistant.components.pilight as pilight
 from homeassistant.components.switch import (SwitchDevice, PLATFORM_SCHEMA)
 from homeassistant.const import (CONF_NAME, CONF_ID, CONF_SWITCHES, CONF_STATE,
-                                 CONF_PROTOCOL)
+                                 CONF_PROTOCOL, STATE_ON)
+from homeassistant.helpers.entity import generate_entity_id


'homeassistant.helpers.entity.generate_entity_id' imported but unused

andrey-git · 2017-08-22T10:17:53Z

homeassistant/components/switch/pilight.py


 _LOGGER = logging.getLogger(__name__)

+DOMAIN = 'switch'


Import ENTITY_ID_FORMAT from component instead.

Why do you need it at all?

This is a leftover from the entity-id-generation that was there in an earlier version.

Is there any documentation anywhere what entity ids are generated, who is responsible and at which point in time I can be sure that it exist?

houndci-bot · 2017-08-22T14:11:31Z

homeassistant/components/switch/pilight.py

+    @property 
+    def assumed_state(self): 
+        """Return True if unable to access real state of the entity.""" 
+        return True 


trailing whitespace

houndci-bot · 2017-08-22T14:11:31Z

homeassistant/components/switch/pilight.py

@@ -130,6 +139,11 @@ def should_poll(self):
        """No polling needed, state set when correct code is received."""
        return False

+    @property 
+    def assumed_state(self): 
+        """Return True if unable to access real state of the entity.""" 


trailing whitespace

houndci-bot · 2017-08-22T14:11:31Z

homeassistant/components/switch/pilight.py

@@ -130,6 +139,11 @@ def should_poll(self):
        """No polling needed, state set when correct code is received."""
        return False

+    @property 
+    def assumed_state(self): 


trailing whitespace

houndci-bot · 2017-08-22T14:11:31Z

homeassistant/components/switch/pilight.py

@@ -130,6 +139,11 @@ def should_poll(self):
        """No polling needed, state set when correct code is received."""
        return False

+    @property 


trailing whitespace

pvizeli · 2017-08-22T14:13:47Z

We can merg it after test have pass.

@janLo you can use customize for change the assume state flag. But the default should be correct.

homeassistant added cla-signed platform: switch.pilight labels Jul 21, 2017

pvizeli requested changes Jul 21, 2017

View reviewed changes

janLo force-pushed the pilight-state-restore branch from 821a9e6 to 1dd1cc5 Compare July 26, 2017 13:57

homeassistant added the cla-signed label Jul 26, 2017

houndci-bot reviewed Jul 26, 2017

View reviewed changes

janLo force-pushed the pilight-state-restore branch from 1dd1cc5 to 29411e1 Compare July 26, 2017 14:05

homeassistant added the cla-signed label Jul 26, 2017

balloobbot added the platform label Jul 26, 2017

pvizeli requested changes Jul 28, 2017

View reviewed changes

janLo added 3 commits August 17, 2017 15:32

Make hound happy

d904f54

Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>

Remove entity_id generation as requested in review.

6887040

janLo force-pushed the pilight-state-restore branch from 3a06dc8 to 6887040 Compare August 17, 2017 13:33

homeassistant added the cla-signed label Aug 17, 2017

houndci-bot reviewed Aug 17, 2017

View reviewed changes

Make hound happy again.

3621f89

homeassistant added the cla-signed label Aug 17, 2017

andrey-git reviewed Aug 22, 2017

View reviewed changes

fix comments

6ec781c

houndci-bot reviewed Aug 22, 2017

View reviewed changes

pvizeli approved these changes Aug 22, 2017

View reviewed changes

fix lint

f576a55

pvizeli merged commit fd6fd76 into home-assistant:dev Aug 22, 2017

balloob mentioned this pull request Aug 25, 2017

0.52 #9131

Merged

home-assistant locked and limited conversation to collaborators Dec 11, 2017

ghost added integration: pilight and removed platform: switch.pilight labels Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pilight switch: restore last state after restart #8580

Pilight switch: restore last state after restart #8580

janLo commented Jul 21, 2017

mention-bot commented Jul 21, 2017

pvizeli left a comment •

edited

janLo commented Jul 21, 2017

pvizeli commented Jul 23, 2017 •

edited

janLo commented Jul 25, 2017

houndci-bot Jul 26, 2017

houndci-bot Jul 26, 2017

janLo commented Jul 26, 2017

janLo commented Jul 26, 2017

janLo commented Jul 26, 2017

pvizeli Jul 28, 2017

janLo Aug 17, 2017

houndci-bot Aug 17, 2017

andrey-git Aug 22, 2017

janLo Aug 22, 2017

houndci-bot Aug 22, 2017

houndci-bot Aug 22, 2017

houndci-bot Aug 22, 2017

houndci-bot Aug 22, 2017

pvizeli commented Aug 22, 2017

Pilight switch: restore last state after restart #8580

Pilight switch: restore last state after restart #8580

Conversation

janLo commented Jul 21, 2017

Description:

Checklist:

mention-bot commented Jul 21, 2017

pvizeli left a comment • edited

Choose a reason for hiding this comment

janLo commented Jul 21, 2017

pvizeli commented Jul 23, 2017 • edited

janLo commented Jul 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janLo commented Jul 26, 2017

janLo commented Jul 26, 2017

janLo commented Jul 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pvizeli commented Aug 22, 2017

pvizeli left a comment •

edited

pvizeli commented Jul 23, 2017 •

edited