New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zha: Update to bellows 0.3.4 #8594

Merged
merged 1 commit into from Jul 22, 2017

Conversation

Projects
None yet
5 participants
@rcloran
Member

rcloran commented Jul 22, 2017

Description:

Related issue (if applicable): fixes #7473 , fixes #8532

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@mention-bot

This comment has been minimized.

mention-bot commented Jul 22, 2017

@rcloran, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @rmkraus to be potential reviewers.

@rcloran

This comment has been minimized.

Member

rcloran commented Jul 22, 2017

I'd like to request this for 0.49.1, if one is planned. I don't know how to do that.

@rcloran

This comment has been minimized.

Member

rcloran commented Jul 22, 2017

Hrm - there's a log message I keep getting reports about. Let me build 0.3.4 to drop the level of that.

@rcloran rcloran changed the title from zha: Update to bellows 0.3.3 to zha: Update to bellows 0.3.4 Jul 22, 2017

@balloob balloob added this to the 0.49.1 milestone Jul 22, 2017

@balloob balloob merged commit 8d31c5f into home-assistant:dev Jul 22, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.669%
Details
hound No violations found. Woof!
@balloob

This comment has been minimized.

Member

balloob commented Jul 22, 2017

I'll prepare a release tomorrow 👍

balloob added a commit that referenced this pull request Jul 24, 2017

@balloob balloob referenced this pull request Jul 24, 2017

Merged

0.49.1 #8625

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.