Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Amcrest version #8624

Merged
merged 1 commit into from Jul 24, 2017
Merged

Conversation

tchellomello
Copy link
Contributor

Description:

Bumping Amcrest version to fix issue #8551 which makes Amcrest data serializable to work via discovery platform.

Related issue (if applicable): fixes #8551

Example entry for configuration.yaml (if applicable):

#configuration.yaml
amcrest: !include amcrest.yaml

#amcrest.yaml
- host: !secret amcrest_driveway_host
  name: "Amcrest Driveway"
  username: !secret amcrest_driveway_username
  password: !secret amcrest_driveway_password
  port: 80
  resolution: high
  stream_source: rtsp
  sensors:
    - motion_detector

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@mention-bot
Copy link

@tchellomello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @flyte, @fabaff and @balloob to be potential reviewers.

@tchellomello tchellomello mentioned this pull request Jul 24, 2017
@balloob balloob merged commit 3fec295 into home-assistant:dev Jul 24, 2017
balloob pushed a commit that referenced this pull request Jul 24, 2017
@balloob balloob added this to the 0.49.1 milestone Jul 24, 2017
@tchellomello tchellomello deleted the fix_issue_8551 branch July 24, 2017 06:49
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recorder/amcrest issue
4 participants