Google Actions for Assistant #9632

philk · 2017-09-30T21:29:59Z

Description:

I'm looking for some feedback on this both as a component and as a specific implementation.

The current emulated_hue implementation can only work with either the Echo or Google Home, but not both at the same time so I took some of the ideas from the Alexa component.

Google provides a Smart Home API for interacting with Google Assistant. It's a relatively straightforward API that just requires some mapping of Home-Assistant objects to a couple of schemas. I think that part all makes sense and is a reasonable component for hass. I will acknowledge there was a lot of copy paste from the hue and Alexa components to figure out how aiohttp works. Happy to take feedback on the /right/ way to do things for sure 😅

Where I'm most looking for feedback though is really UX, basically the Google Actions deploy and setup process. You have to set up OAuth for your action to authenticate against and the way I did it is...hacky to say the least. I'm really curious what the path forward for the Cloud Auth stuff is but right now it looks pretty AWS specific and more for handling login to hass rather than being an OAuth provider.

I'm also not super happy with having to ask people to go through the setup steps for creating an app in GCP. We could probably break it down to:

Download Google's gactions tool
Copy a json file and fill in some fields
Run the gactions test command with the json file

Which isn't /too/ bad but doesn't feel as user friendly as hass has gotten lately (OMG, not having to deal with Zwave compilation and install, life saving).

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3657

Example entry for `configuration.yaml` (if applicable):

google_assistant:
  project_id: someproject-2d0b8
  client_id: supersecretid
  access_token: extradoublesecrettoken
  exposed_domains:
    - switch
    - cover
    - light
    - group

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New files were added to .coveragerc.

homeassistant · 2017-09-30T21:30:00Z

Hello @philk,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

37db7d3fed4efa497cd8230bbbea960eef08175d - This commit has something that looks like an email address (pkates@salesforce.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting Author Name and email@address.com for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

balloob

This is awesome and off to a great start! Yes, OAuth2 is currently pretty cumbersome but that's something we can improve later. I think for now the current flow is fine.

Added some comments, mainly around let's follow the pattern in alexa/smart_home.py and decouple message handling from I/O.

balloob · 2017-10-01T00:12:05Z

.coveragerc

@@ -74,6 +74,9 @@ omit =
    homeassistant/components/google.py
    homeassistant/components/*/google.py

+    homeassistant/components/googleactions.py


This is not needed, you wrote tests 👍

balloob · 2017-10-01T00:14:38Z