Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app-header-background-color as the default variable to set statusBar color. #531

Closed
Knapoc opened this issue Jan 17, 2020 · 3 comments
Closed

Comments

@Knapoc
Copy link

Knapoc commented Jan 17, 2020

Recently a new variable, app-header-background-color, got introduced to set the header color. Since the companion app uses primary-color and falls back to the default theme to set the statusBar color, some themes look off.

I think the logic should be following this order:

  1. use app-header-background-color if defined
  2. use primary-color if defined
  3. assume that the default theme is used

Image of app-header-background-color

@Phontana
Copy link

I'd like this one as well, since primary color isn't always the color you want for the status bar. Is it also possible to specify the color of the status bar icons (light/dark) by using a variable? This would make the modification of the status bar even more powerful, because right now the status bar text is always light and that makes it invisible on light status bar backgrounds.

@dwainscheeren
Copy link

And what @Phontana says a option to set the statusbar to dark mode?

@Phontana
Copy link

@dwainscheeren I will create another issue for that, and maybe a PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants