This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Rectangular Icons #13
Labels
Comments
|
Yes, I added it originally on the README but will keep track of the progress in the issue now. |
connectdotz
added a commit
to connectdotz/Iconic
that referenced
this issue
Jul 18, 2016
addressing issue home-assistant#13, home-assistant#2: move most logic into protocol so Iconic class is just a wrapper class housing icons specific API generated for objective-c compatibility only.
Closed
connectdotz
added a commit
to connectdotz/Iconic
that referenced
this issue
Jul 20, 2016
… maybe home-assistant#13 (although haven’t thoroughly tested yet). outline changes: 1. Updated Iconizer.sh and the stencil files in order to generate multiple fonts without name collision and support the refactoring below. 2. refactor the Iconic.swift and stencils to generate more swifty code that better align with swift3 API guideline: guideline: 2.1. move most of the logic from Iconic.swift to the new protocol "IconFont" 2.2. Iconic class is now a placeholder to house the generated wrapper functions for objective-c compatibility (since they can't access enum extension and protocol). 2.3 the UI extensions become just thin wrappers around the powerful swift enum mainly for objective-c access. (note: Samples/Pods/Iconic/Source/FontAwesomeIcon.swift is generated from the new stencil/Iconizer.sh) 3. chnage catalog location and hierarchy in code generation to accomendate multi-font. 4. Changed Sample swift controllers to use the new style API. 5. Adjust unit tests accordingly; I did disable the UI extension tests since they are nothing more than generated wrappers on the enum class that have already been tested in other 2 unit tests. The UI extensions are also exercised in both swift and objective-c controllers in the Sample project and they worked fine.
Closed
|
With the latest in master, you can now set a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Awesome Lib. Is support for rectangular non-square icons on the roadmap?
The text was updated successfully, but these errors were encountered: