Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled=false addon_pwned doesn't work anymore #2951

Closed
michalk-k opened this issue Jun 10, 2021 · 0 comments · Fixed by #2952
Closed

enabled=false addon_pwned doesn't work anymore #2951

michalk-k opened this issue Jun 10, 2021 · 0 comments · Fixed by #2952
Labels

Comments

@michalk-k
Copy link

Describe the issue you are experiencing

Option
ha resolution check options --enabled=false addon_pwned
has been advertised on HA forum in the middle of March, see https://community.home-assistant.io/t/block-ha-from-sending-out-passwords-to-third-party/286628/124

Today, this option doesn't work. Entering this command ends with error

ERRO[0000] Unexpected server response
Unexpected server response

I don't know if whole feature of disabling sending password hash is nonfunctional or just cli doesn't accept the command

What is the used version of the Supervisor?

supervisor-2021.05.4

What type of installation are you running?

Home Assistant OS

Which operating system are you running on?

Home Assistant Operating System

What is the version of your installed operating system?

5.5

What version of Home Assistant Core is installed?

core-2021.1.5

Steps to reproduce the issue

  1. Open Terminal login to HA instance
  2. enter ha resolution check options --enabled=false addon_pwned

Anything in the Supervisor logs that might be useful for us?

21-06-10 12:22:03 INFO (MainThread) [supervisor.api.middleware_security] /resolution/check/addon_pwned/options access from a0d7b954_ssh
21-06-10 12:22:03 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_protocol.py", line 422, in _handle_request
    resp = await self._request_handler(request)
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/aiohttp.py", line 123, in sentry_app_handle
    reraise(*_capture_exception(hub))
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/_compat.py", line 54, in reraise
    raise value
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/aiohttp.py", line 113, in sentry_app_handle
    response = await old_handle(self, request)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 499, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_middlewares.py", line 119, in impl
    return await handler(request)
  File "/usr/src/supervisor/supervisor/api/middleware_security.py", line 135, in system_validation
    return await handler(request)
  File "/usr/src/supervisor/supervisor/api/middleware_security.py", line 197, in token_validation
    return await handler(request)
  File "/usr/src/supervisor/supervisor/api/utils.py", line 65, in wrap_api
    answer = await method(api, *args, **kwargs)
  File "/usr/src/supervisor/supervisor/api/resolution.py", line 93, in options_check
    check.enabled = body[ATTR_ENABLED]
AttributeError: can't set attribute

I also can see in log several occurrences of:

21-06-10 11:40:51 WARNING (MainThread) [supervisor.resolution.check] Skipping disabled check addon_pwned

Really confused in how should I understand this message.



### Additional information

_No response_
@michalk-k michalk-k added the bug label Jun 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant