Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dx): alias schema to lookup helpers #72

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Conversation

becomingbabyman
Copy link
Member

PR Description

PR Checklist

Testing

  • added relevant test coverage
  • no tests needed

Docs

Typescript

  • added or edited relevant Typescript type declarations
  • no type declaration updates needed

Merging

For maintainers.

To merge, select "Squash and Merge". Then:

  1. Make sure the top commit message follows Angular Git Commit Guidelines,
  2. Delete all other commit messages in the description, but keep any lines designating co-authors so contributors will retain credit for their contributions.

@becomingbabyman becomingbabyman added the enhancement New feature or request label Mar 6, 2021
@becomingbabyman becomingbabyman self-assigned this Mar 6, 2021
@vercel
Copy link

vercel bot commented Mar 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

homebase-example-counter – ./examples/counter

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-counter/EVNYH3Edc2wZUDDEZFQaRBUJwgZG
✅ Preview: https://homebase-example-counter-git-fix-error-msgs-homebaseio.vercel.app

homebase-example-todo – ./examples/todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-todo/8wBaHc7aS3n264L4E8esVydi7mT1
✅ Preview: https://homebase-example-todo-git-fix-error-msgs-homebaseio.vercel.app

homebase-example-ts-firebase-todo – ./examples/typescript-firebase-todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-ts-firebase-todo/DerdgbcDWq1NixufZcDW6QkFu643
✅ Preview: https://homebase-example-ts-firebase-todo-git-fix-error-msgs-homebaseio.vercel.app

homebase-example-roam – ./examples/roam

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-roam/HShzxgrKCnE7rZ7amCye64xw9htn
✅ Preview: https://homebase-example-roam-git-fix-error-msgs-homebaseio.vercel.app

@becomingbabyman
Copy link
Member Author

FYI the Vercel previews of the todo examples will not work since they're pulling homebase-react from npm and lookupHelpers isn't published yet. They should work once this PR is merged. I made sure to update the package.json of each example to grab the latest version of homebase-react.

Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa amazing how much clearer this name change makes things when reading this all over again. No more having to wonder what kinds of "schema" we support vs not. Thanks for getting this in! LGTM!!

@becomingbabyman becomingbabyman merged commit 4a7b1f9 into master Mar 6, 2021
@becomingbabyman becomingbabyman deleted the fix-error-msgs branch March 6, 2021 20:02
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

🎉 This PR is included in version 0.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants