Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console.log): add custom chrome formatters #85

Merged
merged 18 commits into from
Apr 7, 2021
Merged

fix(console.log): add custom chrome formatters #85

merged 18 commits into from
Apr 7, 2021

Conversation

becomingbabyman
Copy link
Member

@becomingbabyman becomingbabyman commented Apr 4, 2021 •
edited

PR Description

PR Checklist

Testing

  • added relevant test coverage
  • no tests needed

Docs

Typescript

  • added or edited relevant Typescript type declarations
  • no type declaration updates needed

Merging

For maintainers.

To merge, select "Squash and Merge". Then:

  1. Make sure the top commit message follows Angular Git Commit Guidelines,
  2. Delete all other commit messages in the description, but keep any lines designating co-authors so contributors will retain credit for their contributions.

@becomingbabyman becomingbabyman added bug Something isn't working enhancement New feature or request labels Apr 4, 2021
@becomingbabyman becomingbabyman self-assigned this Apr 4, 2021
@vercel
Copy link

vercel bot commented Apr 4, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

homebase-example-counter – ./examples/counter

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-counter/FRb9J6DbwgcKm52fXE9Sz6p96mRn
✅ Preview: https://homebase-examp-git-chrome-custom-formatters-hom-c5bb4f.vercel.app

homebase-example-todo – ./examples/todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-todo/BPky1ULjPzhSdPL2PSkYUAzMEWPY
✅ Preview: https://homebase-example-todo-git-chrome-custom-formatters-homebaseio.vercel.app

homebase-example-ts-firebase-todo – ./examples/typescript-firebase-todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-ts-firebase-todo/GYVn8R1xeJx5TUpqFL1G9to23hSg
✅ Preview: https://homebase-examp-git-chrome-custom-formatters-hom-f717dd.vercel.app

homebase-example-roam – ./examples/roam

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-roam/jvJzyYaA8gfSs1uPPguUGUc9VPYU
✅ Preview: https://homebase-example-roam-git-chrome-custom-formatters-homebaseio.vercel.app

rubinovitz
rubinovitz suggested changes Apr 4, 2021
View reviewed changes
Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super exciting! Added a couple of comments.

README.md Outdated Show resolved Hide resolved
src/dev/example/js/todo.jsx Show resolved Hide resolved
@rubinovitz
Copy link
Contributor

Also looks like a test is failing?

@becomingbabyman becomingbabyman removed the bug Something isn't working label Apr 7, 2021
@becomingbabyman becomingbabyman merged commit e74f757 into master Apr 7, 2021
@becomingbabyman becomingbabyman deleted the chrome-custom-formatters branch April 7, 2021 16:36
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

🎉 This PR is included in version 0.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@becomingbabyman becomingbabyman mentioned this pull request Apr 7, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubinovitz rubinovitz rubinovitz approved these changes

Assignees

@becomingbabyman becomingbabyman

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@becomingbabyman @rubinovitz