feat(datalog-console): add datalog-console #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/homebase/datalog_console.cljs
Outdated
| (:require [goog.object :as gobj] | ||
| [cljs.reader])) | ||
|
|
||
| (js/document.documentElement.setAttribute "__datalog-inspect-remote-installed__" true) |
There was a problem hiding this comment.
":datalog-console.remote/installed?"
There was a problem hiding this comment.
Seems that these special characters are not allowed as an attribute on html document. Changed it to "datalog-console-remote-installed"
src/homebase/datalog_console.cljs
Outdated
|
|
||
| (js/document.documentElement.setAttribute "__datalog-inspect-remote-installed__" true) | ||
|
|
||
| (defn init-datalog-console |
src/homebase/react.cljs
Outdated
| @@ -7,7 +7,10 @@ | |||
| [clojure.set] | |||
| [homebase.js :as hbjs] | |||
| [datascript.core :as d] | |||
| [datascript.impl.entity :as de])) | |||
| [datascript.impl.entity :as de] | |||
| [homebase.datalog-console :as console])) | |||
src/homebase/react.cljs
Outdated
| @@ -134,6 +137,7 @@ | |||
| conn (d/create-conn (if schema | |||
| (merge (hbjs/js->schema schema) base-schema) | |||
| base-schema))] | |||
| (console/init-datalog-console {:conn conn}) ; initialise listener for datalog admin console | |||
There was a problem hiding this comment.
I don't think the comment is needed. The naming is clear enough
…omebase-react into datalog-console-integration
becomingbabyman
approved these changes
May 13, 2021
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rubinovitz
reviewed
Jun 25, 2021
| (:require [goog.object :as gobj] | ||
| [cljs.reader])) | ||
|
|
||
| (js/document.documentElement.setAttribute "__datalog-console-remote-installed__" true) |
There was a problem hiding this comment.
@groundedsage it looks like this breaks Next.js support for HBR with the following error:
error - ReferenceError: document is not defined
at /Users/jb/repos/supabase-js/example/next-todo/node_modules/homebase-react/dist/js/homebase.react.js:1491:479
at /Users/jb/repos/supabase-js/example/next-todo/node_modules/homebase-react/dist/js/homebase.react.js:6:22
at Object.<anonymous> (/Users/jb/repos/supabase-js/example/next-todo/node_modules/homebase-react/dist/js/homebase.react.js:10:3)
at Module._compile (internal/modules/cjs/loader.js:1063:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at eval (webpack-internal:///homebase-react:1:18)
Installing CLJS DevTools 1.0.2 and enabling features :formatters :hints :async
ReferenceError: document is not defined
at /Users/jb/repos/supabase-js/example/next-todo/node_modules/homebase-react/dist/js/homebase.react.js:1491:479
at /Users/jb/repos/supabase-js/example/next-todo/node_modules/homebase-react/dist/js/homebase.react.js:6:22
at Object.<anonymous> (/Users/jb/repos/supabase-js/example/next-todo/node_modules/homebase-react/dist/js/homebase.react.js:10:3)
at Module._compile (internal/modules/cjs/loader.js:1063:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at eval (webpack-internal:///homebase-react:1:18)
CLJS DevTools: some custom formatters were not rendered.
https://github.com/binaryage/cljs-devtools/blob/master/docs/faq.md#why-some-custom-formatters-were-not-rendered
CLJS DevTools: some custom formatters were not rendered.
https://github.com/binaryage/cljs-devtools/blob/master/docs/faq.md#why-some-custom-formatters-were-not-rendered
Can you please do error catching here and make it a warning when it fails vs breaking compilation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds a way to signal that a Datalog DB is available to the Chrome extension.
Adds a listener to receive a request for the database as a string and send it as a string to the Chrome extension.
PR Checklist
Testing
Docs
Typescript
Merging
For maintainers.
To merge, select "Squash and Merge". Then: