Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add entity and query functions #93

Merged
merged 3 commits into from
May 6, 2021

Conversation

becomingbabyman
Copy link
Member

@becomingbabyman becomingbabyman commented May 6, 2021

PR Description

PR Checklist

Testing

  • added relevant test coverage
  • no tests needed

Docs

Typescript

  • added or edited relevant Typescript type declarations
  • no type declaration updates needed

Merging

For maintainers.

To merge, select "Squash and Merge". Then:

  1. Make sure the top commit message follows Angular Git Commit Guidelines,
  2. Delete all other commit messages in the description, but keep any lines designating co-authors so contributors will retain credit for their contributions.

@becomingbabyman becomingbabyman added the enhancement New feature or request label May 6, 2021
@becomingbabyman becomingbabyman self-assigned this May 6, 2021
@vercel
Copy link

vercel bot commented May 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

homebase-example-counter – ./examples/counter

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-counter/Gesp2BBdsYKRm1sacyWPwd8SSQUR
✅ Preview: https://homebase-examp-git-add-entity-and-query-to-client-hom-b6596b.vercel.app

homebase-example-todo – ./examples/todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-todo/2vABcyWaCHYgTH49qMsAWyjR758r
✅ Preview: https://homebase-examp-git-add-entity-and-query-to-client-hom-75d0e3.vercel.app

homebase-example-ts-firebase-todo – ./examples/typescript-firebase-todo

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-ts-firebase-todo/6k4d3uMjstcDjZZrmcJr2fmNNT14
✅ Preview: https://homebase-examp-git-add-entity-and-query-to-client-hom-97656c.vercel.app

homebase-example-roam – ./examples/roam

🔍 Inspect: https://vercel.com/homebaseio/homebase-example-roam/En5aeamToF7Yv7ubRaYMJ9AG9NXi
✅ Preview: https://homebase-examp-git-add-entity-and-query-to-client-hom-99f263.vercel.app

@becomingbabyman becomingbabyman linked an issue May 6, 2021 that may be closed by this pull request
Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Cool we could do this with such little code.

One thing: I can't check this since I'm sick and AFC, but does it make sense to update typescript types here?

@becomingbabyman
Copy link
Member Author

This looks good to me! Cool we could do this with such little code.

One thing: I can't check this since I'm sick and AFC, but does it make sense to update typescript types here?

Yep, just updated them. I noticed them in the checklist. Love that thing!

rubinovitz
rubinovitz previously approved these changes May 6, 2021
Copy link
Contributor

@rubinovitz rubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you!

@becomingbabyman becomingbabyman merged commit 36f00cc into master May 6, 2021
@becomingbabyman becomingbabyman deleted the add-entity-and-query-to-client branch May 6, 2021 22:38
@github-actions
Copy link

github-actions bot commented May 6, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for documentation of usage without react
2 participants