Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basic authentication support for GitHub. #10045

Merged
merged 1 commit into from Dec 17, 2020
Merged

Remove basic authentication support for GitHub. #10045

merged 1 commit into from Dec 17, 2020

Conversation

jonchang
Copy link
Contributor

Since we (and GitHub) no longer support password authentication using non-token passwords, always set the Authorization header, rather than needlessly checking for a (possibly incorrect) username. This also simplifies the code.

Fixes issue identified in Homebrew/discussions#273 (comment).

Tested on brew pr-pull --verbose and confirmed that it behaves as expected (not passing --user foo:*** and instead passing --header Authorization: token *** to curl)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Since we (and GitHub) no longer support password authentication
using non-token passwords, always set the Authorization header,
rather than needlessly checking for a (possibly incorrect) username.
@BrewTestBot
Copy link
Member

Review period will end on 2020-12-18 at 12:18:35 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 17, 2020
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 17, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 17, 2020

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 17, 2020
@MikeMcQuaid MikeMcQuaid merged commit 9db324a into Homebrew:master Dec 17, 2020
@MikeMcQuaid
Copy link
Member

Thanks @jonchang!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 17, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 17, 2021
@jonchang jonchang deleted the remove-basic-autho branch February 12, 2021 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants