Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Make
ignore_interrupts
raise anInterrupt
exception afterwards if there was an an attempt to interrupt it.If I press CTRL-C, I expect
brew
to exit after the “One sec, cleaning up...” message and not continue running until I happen to find a “correct” position where pressing CTRL-C actually works.Change
SystemCommand
to spawn processes in another process group, so that the parent process can sendSIGINT
to the child rather than the child receiving it directly. We want to raise anInterrupt
exception rather than the child exiting with aProcess::Status
containing only a signal but no actual exit status.