Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump-cask-pr: ignore closed duplicate PRs #10109

Merged
merged 1 commit into from Dec 28, 2020
Merged

bump-cask-pr: ignore closed duplicate PRs #10109

merged 1 commit into from Dec 28, 2020

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This PR adds the --ignore-closed-prs switch that allows a bump PR to be opened regardless of whether or not the same PR has already been opened before. See Homebrew/homebrew-cask#93014

the version numbers of casks change a lot, not only up, sometimes down and up again too. there are examples each day. also some contributors close perfectly fine PRs. this means the same PR cannot be sent again although it needs to be sent. i have a system that downloads each cask with a static download URL every 4 hours and the PRs it generates are guaranteed to be 100% accurate. however they often fail to send because of limitations in 'brew bump-cask-pr'.

Resolves #9466

@SeekingMeaning SeekingMeaning added the cask Homebrew Cask label Dec 23, 2020
@BrewTestBot
Copy link
Member

Review period will end on 2020-12-24 at 09:42:25 UTC.

1 similar comment
@BrewTestBot
Copy link
Member

Review period will end on 2020-12-24 at 09:42:25 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 23, 2020
MikeMcQuaid
MikeMcQuaid approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as a default. I wonder if we even really need the option?

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 24, 2020
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid
Copy link
Member

I wonder if we even really need the option?

Unless you strongly feel "yes": I'd suggest removing it.

@SeekingMeaning SeekingMeaning changed the title bump-cask-pr: add --ignore-closed-prs switch bump-cask-pr: ignore closed duplicate PRs Dec 24, 2020
@MikeMcQuaid MikeMcQuaid merged commit 6e2da86 into Homebrew:master Dec 28, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @SeekingMeaning!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 28, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew bump-cask-pr changes requested by homebrew-cask maintainers
3 participants
@SeekingMeaning @BrewTestBot @MikeMcQuaid