dev-cmd/unbottled: improve output. #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2020-12-25 at 14:08:16 UTC. |
BrewTestBot
added
the
waiting for feedback
|
Looks good, thanks @MikeMcQuaid |
MikeMcQuaid
force-pushed
the
unbottled-tweaks
branch
from
8046cdb
to
b13180b
Compare
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Dec 25, 2020
fxcoudert
approved these changes
Dec 25, 2020
MikeMcQuaid
force-pushed
the
unbottled-tweaks
branch
2 times, most recently
from
6239620
to
7a797ac
Compare
Handle a few more edge cases: - improve the unbottled output heading so it makes sense when we're outputting bottles that are ready to bottle - output already bottled formulae if named - handle Linux/Mac requiring formulae and output if named - output bottle unneeded/disabled formulae if named - use green/yellow/red for bottles ready to be built now/later/never
MikeMcQuaid
force-pushed
the
unbottled-tweaks
branch
from
7a797ac
to
d20b946
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle a few more edge cases beyond #10110: