mktemp: avoid directories with @ #10162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxcoudert
added
the
critical
|
Review period ended. |
BrewTestBot
approved these changes
Dec 28, 2020
BrewTestBot
approved these changes
Dec 28, 2020
MikeMcQuaid
approved these changes
Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for some build tools that have trouble building if the current path contains a
@This was originally proposed #9007 in the context of versioned gcc formulas, but I fixed the bug upstream and we decided we didn't want to change it in brew.
Now it appears that this is also an issue with ninja (ninja-build/ninja#1606) and it doesn't look like they're actively working on it. (They use the
@character for another special meaning). This is currently blocking the build ofqt@5: Homebrew/homebrew-core#67536Given that… I suggest we include this workaround in brew. Other that the slight effect of surprise, I don't really see a downside.