Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary downloads in audit. #10199

Merged
merged 1 commit into from Jan 2, 2021

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Since curl_check_http_content was fixed, when auditing the mactex cask, it will first try to download a ~4GB file since it comes from a http:// URL. Only then will it check the https:// URL.

The audit currently fails since the download exceeds the 600 seconds timeout of the audit.

This fixes the function to first check if the https:// URL is reachable and only then download the http:// URL as well. Otherwise, only the reachability of the http:// URL is checked.

@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Jan 2, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@reitermarkus reitermarkus merged commit 4a90a5a into Homebrew:master Jan 2, 2021
@reitermarkus reitermarkus deleted the check-https-content branch January 2, 2021 23:33
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants