Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_auditor: prohibit patches in new core formulae only #10219

Merged
merged 1 commit into from Jan 6, 2021
Merged

formula_auditor: prohibit patches in new core formulae only #10219

merged 1 commit into from Jan 6, 2021

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Jan 4, 2021 •
edited by MikeMcQuaid

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

New formulae in non-core taps should be allowed to specify patch blocks. See #10216 for further discussion.

I briefly looked through the tests but could not find anything that currently tests this audit anyways, so I did not change anything related to tests.

Fixes #10216

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-05 at 19:10:20 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 4, 2021
Rylan12
Rylan12 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@Rylan12 Rylan12 linked an issue Jan 4, 2021 that may be closed by this pull request
brew test-bot doesn't allow formulae with patches #10216
Closed
@alebcay alebcay force-pushed the patch-audit-on-coretap-only branch from a3b6e48 to 199c64d Compare January 5, 2021 14:47
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 5, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@MikeMcQuaid MikeMcQuaid merged commit d617b6d into Homebrew:master Jan 6, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 5, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew test-bot doesn't allow formulae with patches
4 participants
@alebcay @BrewTestBot @MikeMcQuaid @Rylan12