Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: use macos-latest. #10234

Merged
merged 1 commit into from Jan 7, 2021

Conversation

MikeMcQuaid
Copy link
Member

macos-11.0 capacity is too low for us at the moment.

macos-11.0 capacity is too low for us at the moment.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 6, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member Author

@reitermarkus @Homebrew/cask Any idea what's going on with this CI failure:
https://github.com/Homebrew/brew/pull/10234/checks?check_run_id=1656636938#step:15:3505
https://github.com/Homebrew/brew/pull/10234/checks?check_run_id=1656636938#step:15:5621

It's failing repeatedly here but not on master.

@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 6, 2021

Any idea what's going on with this CI failure

Yes. Already made a couple of PRs to fix those and fast-tracked them. As soon as CI passes and those are in, the error should go away.

@vitorgalvao
Copy link
Member

Other PRs are in; rerunning CI on this one.

@reitermarkus
Copy link
Member

reitermarkus commented Jan 6, 2021

It's because we only tested these on Big Sur and they depend on MacOS.version.

@MikeMcQuaid MikeMcQuaid merged commit c79f63d into Homebrew:master Jan 7, 2021
@MikeMcQuaid MikeMcQuaid deleted the macos-latest branch January 7, 2021 10:00
@MikeMcQuaid
Copy link
Member Author

Thanks @vitorgalvao, @reitermarkus!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 7, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants