audit: quieten down and make casks audit consistent with formulae. #10236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2021-01-07 at 13:40:10 UTC. |
BrewTestBot
added
the
waiting for feedback
vitorgalvao
approved these changes
Jan 6, 2021
MikeMcQuaid
force-pushed
the
cask-audit-quieter
branch
2 times, most recently
from
be43263
to
e8f3207
Compare
The current casks audit is very noisy in the no-op case (i.e. no errors) https://github.com/Homebrew/brew/pull/10234/checks?check_run_id=1655630568#step:15:7 This means when there are errors and you're querying all casks it's pretty hard to quickly identify the problems. This commit silences the `passing`, `warning` and header/summary output when you're querying all casks (rather than a specific cask or tap). This is more consistent with `brew audit` for formulae which is silent unless there are audit failures.
MikeMcQuaid
force-pushed
the
cask-audit-quieter
branch
from
e8f3207
to
d8a5e46
Compare
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current casks audit is very noisy in the no-op case (i.e. no errors):
https://github.com/Homebrew/brew/pull/10234/checks?check_run_id=1655630568#step:15:7
This means when there are errors and you're querying all casks it's pretty hard to quickly identify the problems.
This commit silences the
passing,warningand header/summary output when you're querying all casks (rather than a specific cask or tap).This is more consistent with
brew auditfor formulae which is silent unless there are audit failures.