Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops: migrate to rubocop v1 API #10300

Merged
merged 19 commits into from Jan 13, 2021
Merged

rubocops: migrate to rubocop v1 API #10300

merged 19 commits into from Jan 13, 2021

Conversation

jonchang
Copy link
Contributor

See https://docs.rubocop.org/rubocop/v1_upgrade_notes.html for details. Presumably the legacy APIs we were using will go away in Rubocop v2, so let's migrate these now so we don't continue to add new audits that use APIs that will go away one day.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-13 at 08:06:58 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 12, 2021
@MikeMcQuaid
Copy link
Member

Thanks @jonchang, good catch here.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 13, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@jonchang jonchang merged commit 71f7ef0 into Homebrew:master Jan 13, 2021
@jonchang jonchang deleted the rubocop-v1-api branch January 13, 2021 10:21
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 13, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants