New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocops: migrate to rubocop v1 API #10300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review period will end on 2021-01-13 at 08:06:58 UTC. |
BrewTestBot
added
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Jan 12, 2021
MikeMcQuaid
approved these changes
Jan 12, 2021
Thanks @jonchang, good catch here. |
BrewTestBot
removed
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Jan 13, 2021
Review period ended. |
BrewTestBot
approved these changes
Jan 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.rubocop.org/rubocop/v1_upgrade_notes.html for details. Presumably the legacy APIs we were using will go away in Rubocop v2, so let's migrate these now so we don't continue to add new audits that use APIs that will go away one day.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?