Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/git_repository: use Pathname.pwd if no repo specified #10306

Merged
merged 1 commit into from Jan 14, 2021

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This will allow formulae to do Utils.git_head instead of Utils.git_head(buildpath)
This is useful for cd blocks such as:

cd "resource-cloned-from-git" do
  resource_commit = Utils.git_head
  # ...
end

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-13 at 19:10:17 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 12, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 13, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@SeekingMeaning SeekingMeaning added waiting for feedback Merging is blocked until sufficient time has passed for review and removed do not merge labels Jan 13, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 13, 2021
@SeekingMeaning SeekingMeaning merged commit 663b972 into Homebrew:master Jan 14, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 14, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants