Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cask tests: temporarily disable broken test #10315

Merged
merged 1 commit into from Jan 13, 2021
Merged

Cask tests: temporarily disable broken test #10315

merged 1 commit into from Jan 13, 2021

Conversation

mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Jan 13, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This test is currently breaking even on master, and has been for about eight hours. It's blocking us from merging new PRs. https://github.com/Homebrew/brew/pull/10312/checks?check_run_id=1696817416

@mistydemeo mistydemeo added cask Homebrew Cask critical Critical change which should be shipped as soon as possible. labels Jan 13, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

1 similar comment
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@mistydemeo mistydemeo merged commit c197e9a into Homebrew:master Jan 13, 2021
@mistydemeo mistydemeo deleted the cask_is_unavailable_hotfix branch January 13, 2021 19:14
@mistydemeo mistydemeo mentioned this pull request Jan 21, 2021
Closed
8 tasks
mistydemeo added a commit to mistydemeo/brew that referenced this pull request Jan 21, 2021
@mistydemeo
curl: remove --continue-at argument
38eba9f 
This has been causing problems with fetching certain files,
for example code from github.com.

See Homebrew#10315.
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 13, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
cask Homebrew Cask critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mistydemeo @BrewTestBot