dev-cmd/tap-new: fix output on newer versions of Git. #10324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this prints to `stderr` to ask for configuration of the branch name: https://github.com/Homebrew/brew/pull/10323/checks?check_run_id=1701105141#step:5:51
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
1 similar comment
|
Review period skipped due to |
BrewTestBot
approved these changes
Jan 14, 2021
BrewTestBot
approved these changes
Jan 14, 2021
|
Doesn't |
It does, yep. Unfortunately we need to handle this in a way that works on older and newer Git versions. It's a no-op if the branch is already named e.g. |
dawidd6
approved these changes
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this prints to
stderrto ask for configuration of the branch name:https://github.com/Homebrew/brew/pull/10323/checks?check_run_id=1701105141#step:5:51