completions: complete files where appropriate in bash #10360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?This is a follow-up to #10229 which adds the ability to complete files where appropriate.
A few commands (
bottle
,ruby
,sh
, andstyle
) accept files as named arguments. This PR will now enable automatic file completion for these commands. Note that this is only available in newer versions ofbash
, so I've added a conditional making the__brew_complete_files
a no-op unless thecompopt
command exists. I've tested using builtin/bin/bash
(nocompopt
command so no file completions) and Homebrew's/usr/local/bin/bash
(withcompopt
and file completions).