Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions: complete files where appropriate in bash #10360

Merged
merged 1 commit into from Jan 20, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jan 19, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This is a follow-up to #10229 which adds the ability to complete files where appropriate.

A few commands (bottle, ruby, sh, and style) accept files as named arguments. This PR will now enable automatic file completion for these commands. Note that this is only available in newer versions of bash, so I've added a conditional making the __brew_complete_files a no-op unless the compopt command exists. I've tested using builtin /bin/bash (no compopt command so no file completions) and Homebrew's /usr/local/bin/bash (with compopt and file completions).

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-20 at 04:58:03 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 19, 2021
@MikeMcQuaid
Copy link
Member

Nice work again @Rylan12!

Note that this is only available in newer versions of bash

Which versions, out of interest?

@Rylan12
Copy link
Member Author

Rylan12 commented Jan 19, 2021

Which versions, out of interest?

The compopt command was added in version 4.0. Apple's built-in bash is verion 3.2

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 20, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@Rylan12 Rylan12 merged commit e172f07 into Homebrew:master Jan 20, 2021
@Rylan12 Rylan12 deleted the bash-completions-files branch January 20, 2021 14:29
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 20, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants