dev-cmd: disable when broken on Apple Silicon. #10375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better than users getting a weird error.
|
Review period will end on 2021-01-21 at 14:08:38 UTC. |
BrewTestBot
added
the
waiting for feedback
3 tasks
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Jan 20, 2021
dtrodrigues
reviewed
Jan 21, 2021
| EOS | ||
|
|
||
| named_args :none | ||
| end | ||
| end | ||
|
|
||
| def install_bundler_gems | ||
| # TODO: update description above if removing this. | ||
| raise UsageError, "not (yet) working on Apple Silicon!" if Hardware::CPU.arm? |
There was a problem hiding this comment.
Maybe we can allow this command but block the commands we know don't work? Using the system ruby, install-bundler-gems does install gems, it's just that some don't work.
dtrodrigues
approved these changes
Jan 21, 2021
|
Thanks @dtrodrigues! I reckon it's worth keeping this minimal for now until we've figured out fixes. |
|
This broke ARM CI, I think: https://github.com/Homebrew/homebrew-core/pull/69460/checks?check_run_id=1740727396#step:6:32 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better than users getting a weird error.
Partially addresses #10210