Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: raise failures and handle later. #10389

Merged
merged 1 commit into from Jan 21, 2021
Merged

cleanup: raise failures and handle later. #10389

merged 1 commit into from Jan 21, 2021

Conversation

MikeMcQuaid
Copy link
Member

These are already handled and outputted as a group in cmd/cleanup.rb.

Fixes #10379

@MikeMcQuaid
cleanup: raise failures and handle later.
15761a2 
These are already handled and outputted as a group in `cmd/cleanup.rb`.

Fixes #10379
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 21, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit f6bc3ef into Homebrew:master Jan 21, 2021
@MikeMcQuaid MikeMcQuaid deleted the cleanup_raise branch January 21, 2021 15:55
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 21, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't fail when cleanup fails
2 participants
@MikeMcQuaid @BrewTestBot