Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HOMEBREW_BOOTSNAP setup #10390

Merged
merged 1 commit into from Jan 22, 2021
Merged

Conversation

MikeMcQuaid
Copy link
Member

  • rename to homebrew_bootsnap.rb to avoid conflicting with the bootsnap.rb we need to require
  • if the require fails: run bundler (until we vendor this gem)

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 21, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid force-pushed the bootsnap_fix branch 2 times, most recently from ca92576 to 2efec39 Compare January 21, 2021 16:31
- rename to `homebrew_bootsnap.rb` to avoid conflicting with the
  `bootsnap.rb` we need to `require`
- if the `require` fails: run bundler (until we vendor this gem)
@MikeMcQuaid MikeMcQuaid merged commit 62c8f2b into Homebrew:master Jan 22, 2021
@MikeMcQuaid MikeMcQuaid deleted the bootsnap_fix branch January 22, 2021 09:38
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 22, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants