Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: improvements #10406

Merged

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

  • If the formula is deprecated because it doesn't build, raise an error.
    • For example, openrtsp will be disabled on 2021-11-22; since we have not yet reached that date, it is treated as a deprecated formula (i.e. disabled? returns false, but deprecated? returns true). We shouldn't open new bump PRs for this formula because we've already tried updating it before, and future versions will most likely continue failing to build.
  • Check if the formula is throttled, and if so, check if the specified new version meets the throttle requirement.
    • For example, raise an error if attempting to bump aws-sdk-cpp with a version that isn't a multiple of 10.
  • Improved regex for filtering duplicate PRs by title.
    • Changed (:|\s|$) to (:|,|\s|$) to include commas as delimiters. For example:
      • brew bump-formula-pr libnetworkit
    • Added custom regex for checking the titles of closed PRs, which allows for PRs that bump multiple formulae to be counted as duplicate PRs. For example:
      • brew bump-formula-pr mysql@5.7 --version=5.7.33
        • Should match this closed PR: mysql@5.7 mysql-client@5.7 5.7.33
        • mysql@5.7 is at the start of the title and is followed by a space.
        • 5.7.33 is at the end of the title and is preceded by a space.
      • brew bump-formula-pr libbtbb --version=2020-12-R1

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-26 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 24, 2021
Copy link
Member

@dawidd6 dawidd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 26, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@SeekingMeaning SeekingMeaning merged commit e5fca67 into Homebrew:master Jan 26, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants