Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/bump: increase test coverage #10417

Merged
merged 1 commit into from Jan 26, 2021
Merged

dev-cmd/bump: increase test coverage #10417

merged 1 commit into from Jan 26, 2021

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This is a follow-up PR to increase brew bump's test coverage after the refactoring PR (#10285).

Summary of changes:

  • Combined repetitive logic into a single method, retrieve_and_display_info.
  • Added a test for HEAD-only formulae.

In hindsight, I shouldn't have removed the do not merge label from the refactoring PR, I didn't notice the decrease in coverage until Sam mentioned it. Sorry! 馃槄

CC @samford

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-26 at 11:49:27 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 25, 2021
@MikeMcQuaid
Copy link
Member

In hindsight, I shouldn't have removed the do not merge label from the refactoring PR, I didn't notice the decrease in coverage until Sam mentioned it. Sorry! 馃槄

Don't worry, I didn't see it as a blocking issue.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 26, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@nandahkrishna nandahkrishna merged commit 5f59302 into Homebrew:master Jan 26, 2021
@nandahkrishna nandahkrishna deleted the bump-tests branch January 26, 2021 13:28
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants