Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottle: write bottles in correct order #10522

Merged
merged 1 commit into from Feb 4, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Feb 4, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Follow up to #10517

This PR fixes brew bottle so it writes the arm bottles first (as described in #10453). I'll open a separate PR to re-enable the style rule (doing them separately makes the process easier and won't require anything nearly as involved as last time).

@BrewTestBot
Copy link
Member

Review period will end on 2021-02-05 at 18:41:23 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 4, 2021
@Rylan12 Rylan12 mentioned this pull request Feb 4, 2021
8 tasks
@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Feb 4, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 4, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12
Copy link
Member Author

Rylan12 commented Feb 4, 2021

Marking as critical and merging to get this in before the potential 3.0.0 release tomorrow.

@Rylan12 Rylan12 merged commit 42b755e into Homebrew:master Feb 4, 2021
@Rylan12 Rylan12 deleted the bottle-correct-order branch February 4, 2021 22:17
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 7, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants