Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/rubocops: Fix mismatched test descriptions #10659

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 20, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

  • After doing rubocop: Enable RSpec/ContextWording cop & fix offenses #10658, I moved onto other TODOs in that file. Enabling RSpec/RepeatedDescription momentarily revealed that two test descriptions had been copypasted between two similar, but not identical, tests. (Actually fixing the other offenses for that cop will be for another day!)

@BrewTestBot
Copy link
Member

Review period will end on 2021-02-23 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 20, 2021
@MikeMcQuaid
Copy link
Member

👏🏻

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 23, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@issyl0 issyl0 merged commit 7a0effd into Homebrew:master Feb 23, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants