Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: Enable RSpec/RepeatedExampleGroupDescription cop & fix offenses #10665

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 21, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

  • Inspired by my other RuboCop PR on Friday, here's another TODO dealt with.

@BrewTestBot
Copy link
Member

Review period will end on 2021-02-23 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 21, 2021
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion that isn't crucial

context "with a file name trailing the URL path" do
let(:url) { "https://example.com/cask.dmg" }

its("cached_location.extname") { is_expected.to eq(".dmg") }
it {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it {
it "returns a file with a `.dmg` extension" {

Might be a good idea to add some sort of description like this to the its to it conversions.

Without a description:

CurlDownloadStrategy#cached_location with a file name trailing the URL path is expected to eq ".dmg"

With a description:

CurlDownloadStrategy#cached_location with a file name trailing the URL path returns a file with a `.dmg` extension

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly didn't add descriptions as the other it {s that I moved down didn't have any. 🤷🏻

@MikeMcQuaid
Copy link
Member

Nice work @issyl0!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 23, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@issyl0 issyl0 merged commit 8dfaad9 into Homebrew:master Feb 23, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants