Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump-cask-pr: support separate downloads for Intel and ARM #10683

Merged
merged 3 commits into from Mar 18, 2021
Merged

bump-cask-pr: support separate downloads for Intel and ARM #10683

merged 3 commits into from Mar 18, 2021

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Supersedes #10345

This PR allows ARM checksums to be updated from Intel Macs by temporarily replacing Hardware::CPU.intel? with false

@SeekingMeaning SeekingMeaning added the cask Homebrew Cask label Feb 23, 2021
@BrewTestBot
Copy link
Member

Review period will end on 2021-02-24 at 17:07:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 23, 2021
@SeekingMeaning SeekingMeaning mentioned this pull request Feb 23, 2021
Closed
8 tasks
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 24, 2021
@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Mar 18, 2021
@SeekingMeaning SeekingMeaning removed the stale No recent activity label Mar 18, 2021
@SeekingMeaning
Copy link
Contributor Author

Homebrew/homebrew-cask#101345

@SeekingMeaning SeekingMeaning merged commit 7cf8ef6 into Homebrew:master Mar 18, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SeekingMeaning @BrewTestBot @MikeMcQuaid