Improve Bootsnap behaviour #10706
Merged
Improve Bootsnap behaviour #10706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 25, 2021
Bo98
reviewed
Feb 25, 2021
Comment on lines
-21
to
+19
| if homebrew_bootsnap_enabled && development_tools_installed | ||
| if homebrew_bootsnap_enabled |
There was a problem hiding this comment.
I'd still have the development_tools_installed and make that check only in the LoadError case, but it doesn't matter much.
Comment on lines
-29
to
+27
| Homebrew.install_bundler_gems! | ||
| Homebrew.install_bundler_gems!(only_warn_on_failure: true) |
There was a problem hiding this comment.
Looks good, but probably quite noisy if it prints a massive block of warnings on every run?
There was a problem hiding this comment.
Yup but I'm not sure what I see as a real workaround for that (particularly now it's no longer default as-of #10704)
- further refactor nested conditional to make it clearer - allow running on Linux while still excluding Apple Silicon - only warn on `bundle install` failures
MikeMcQuaid
force-pushed
the
bootsnap_tweaks
branch
from
8f69ea9
to
60876ee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundle installfailures