Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download_strategy: only take basename of Content-Disposition #10728

Merged
merged 1 commit into from
Feb 27, 2021
Merged

download_strategy: only take basename of Content-Disposition #10728

merged 1 commit into from
Feb 27, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 27, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is breaking netris.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Feb 27, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit 7ab7ace into Homebrew:master Feb 27, 2021
@Bo98 Bo98 deleted the content-disposition-basename branch February 27, 2021 18:42
MikeMcQuaid
MikeMcQuaid reviewed Mar 1, 2021
View reviewed changes
Library/Homebrew/download_strategy.rb
@@ -458,7 +458,7 @@ def resolve_url_basename_time_file_size(url)
filename = URI.decode_www_form_component(encoded_filename).encode(encoding) if encoding && encoded_filename
end

filename || content_disposition.filename
(filename || content_disposition.filename).rpartition("/")[-1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 Can you add a comment here? It's not clear what this is doing or why.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will do.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 1, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bo98 @BrewTestBot @MikeMcQuaid