formula_installer: tweak "no bottle available" logic. #10788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure that `HOMEBREW_DEVELOPER` still fails when there's a bottle available but the `pour_bottle?` block fails. This is usually due to the CLT being missing (and it's removed on even patch macOS upgrades) so building from source without prompt is undesirable. - require `--build-from-source` for dependencies that aren't already installed - do these bottle checks before fetching dependencies (they were already done before fetching requested formulae) Fixes #10729
1 task
|
Review period will end on 2021-03-08 at 12:09:35 UTC. |
BrewTestBot
added
the
waiting for feedback
dtrodrigues
approved these changes
Mar 6, 2021
|
Review period ended. |
BrewTestBot
removed
the
waiting for feedback
BrewTestBot
approved these changes
Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_DEVELOPERstill fails when there's a bottle available but thepour_bottle?block fails. This is usually due to the CLT being missing (and it's removed on even patch macOS upgrades) so building from source without prompt is undesirable.--build-from-sourcefor dependencies that aren't already installedFixes #10729