Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask_loader: do not auto-tap in FromTapLoader #10831

Merged
merged 2 commits into from Mar 12, 2021
Merged

cask_loader: do not auto-tap in FromTapLoader #10831

merged 2 commits into from Mar 12, 2021

Conversation

nandahkrishna
Copy link
Member

@nandahkrishna nandahkrishna commented Mar 11, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR aims to fix #10584, by removing auto-tapping from cask's FromTapLoader.

Output:

➜ brew info mongodb/brew/mongodb-community
Error: No available formula or cask with the name "mongodb/brew/mongodb-community".
Please tap it and then try again: brew tap mongodb/brew

➜ brew info --formula mongodb/brew/mongodb-community
Error: No available formula with the name "mongodb/brew/mongodb-community".
Please tap it and then try again: brew tap mongodb/brew

➜ brew info --cask mongodb/brew/mongodb-community
Error: Cask 'mongodb/brew/mongodb-community' is unavailable.
Please tap it and then try again: brew tap mongodb/brew

@BrewTestBot
Copy link
Member

Review period will end on 2021-03-12 at 15:43:18 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 11, 2021
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 12, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 12, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@nandahkrishna nandahkrishna merged commit 1e3dab1 into Homebrew:master Mar 12, 2021
@nandahkrishna nandahkrishna deleted the cask-autotap branch March 12, 2021 14:40
@MikeMcQuaid
Copy link
Member

Thanks @nandahkrishna !

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew info doesn't re-read available formulae after auto-tap
3 participants