Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand quiet checks in update and update-report #10844

Merged
merged 1 commit into from Mar 15, 2021
Merged

Expand quiet checks in update and update-report #10844

merged 1 commit into from Mar 15, 2021

Conversation

dkav
Copy link
Contributor

@dkav dkav commented Mar 13, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The output from brew update can be voluminous. To reduce what is reported, this pull request expands the --quiet checks in update-report and adds it to update. This follows up on #10581 (comment) and seeks to partially address #10609.

@dkav
Copy link
Contributor Author

dkav commented Mar 13, 2021

I am not familiar with the code base but it seems that the --quiet check in

elsif !args.preinstall? && !ENV["HOMEBREW_UPDATE_FAILED"]
is redundant as it is bypassed by update. Hence the reason for adding --quiet to update in this pull request.

@MikeMcQuaid
Copy link
Member

This makes sense to me. Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock @dkav!

@MikeMcQuaid MikeMcQuaid merged commit 0cf2d30 into Homebrew:master Mar 15, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants