Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language/python: remove outdated "homebrew-" resource handling #10850

Merged
merged 1 commit into from Mar 16, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Mar 14, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The homebrew-* resources were used to separate resources needed for virtualenv from those defined in the formula. We don't use virtualenv anymore so there's no need to handle these differently anymore.

@BrewTestBot
Copy link
Member

Review period will end on 2021-03-16 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 14, 2021
@Rylan12 Rylan12 enabled auto-merge March 14, 2021 19:12
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 16, 2021
@Rylan12 Rylan12 merged commit 1e37fbd into Homebrew:master Mar 16, 2021
@Rylan12 Rylan12 deleted the remove-homebrew-python-resoruces branch March 16, 2021 00:35
@iMichka
Copy link
Member

iMichka commented Mar 16, 2021

This might have broken the magic-wormhole build on Linux, but it's maybe unrelated:
https://github.com/Homebrew/linuxbrew-core/runs/2119521006

@Rylan12
Copy link
Member Author

Rylan12 commented Mar 16, 2021

It's possible but I don't know where the homebrew-* resource would have come from. Feel free to revert this if you feel it is causing problems, though

Actually, I doubt it's related to this. The only change would be that a homebrew-* resource would be installed, whereas before it was skipped. I don't see anything in the logs that would indicate that was happening (just skimmed, though)

@Bo98
Copy link
Member

Bo98 commented Mar 16, 2021

The problem is because a virtualenv is created twice in that formula. It's not new, but I don't know why it isn't consistent in failing at the moment.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants