Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make livecheck audit mandatory for versioned casks. #10894

Merged
merged 1 commit into from Mar 23, 2021

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 20, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Some livechecks work using the auto-detected strategy, but we don't have a way to know the difference between a missing livecheck block and implicitly using the auto-detected strategy.

For now, casks with an existing appcast are still skipped.

@reitermarkus reitermarkus added the cask Homebrew Cask label Mar 20, 2021
@reitermarkus reitermarkus requested a review from a team March 20, 2021 22:51
@BrewTestBot
Copy link
Member

Review period will end on 2021-03-23 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 20, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 23, 2021
@reitermarkus reitermarkus merged commit 3c6a7b3 into Homebrew:master Mar 23, 2021
@reitermarkus reitermarkus deleted the mandatory-livecheck branch March 23, 2021 00:34
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants