Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/github: handle non-standard tap remotes #10895

Merged
merged 2 commits into from Mar 23, 2021

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Mar 21, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #10881

This PR adds a Tap#remote_repo method to extract the remote repository name from the tap remote url. This should be used instead of Tap#full_name for methods in the Utils::GitHub module so that those methods can be used on taps that use non-standard urls.

@BrewTestBot
Copy link
Member

Review period will end on 2021-03-23 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 21, 2021
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Library/Homebrew/tap.rb Outdated Show resolved Hide resolved
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 23, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@Rylan12 Rylan12 merged commit 2d3aca7 into Homebrew:master Mar 23, 2021
@Rylan12 Rylan12 deleted the fix-tap-custom-remote-handling branch March 23, 2021 02:28
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump-formula-pr fails with non-standard tap names
3 participants